Perhaps. But I firmly believe that actors do have say in what and how they choose to fulfill their roll. Mel Gibson has made some horrible, offensive movies. I hear Traditional Catholics make excuses for him “He’s just acting…He uses his money for good things…he sponsors his own chapel…he made the Passion of the Christ…yada, yada, yada…”. All just excuses to rationalize sin.
I might give Lebuf a mulligan since he is new to Catholicism…but…???
I guess my overall question was, have I been misinterpreting Padre Pio as a humble, yet sometimes assertive friar, courageously battling demons in his cell…or was he a sometimes brash, even foul mouthed, angry man while battling these demons?
Well, a Catholic actor should just turn down those scandalous roles (such as Gibson's, for which there's no excuse, since he was raised Traditional Catholic), but evidently LaBeouf was already "signed" and it was during his work preparing for the movie that he converted, so, as you said, I'd give him the mulligan on this one. We'll have to see what he does going forward.
I can't comment on the portrayal of Padre Pio in the move, since I haven't seen it, but Padre Pio was sometimes gruff ... though never known to be foul-mouthed. As for what Padre Pio was really like, I suspect that'll be largely lost to history (and to the ecclesiastical authorities who were looking into him), since there's probably no other figure who's been more mythologized than Padre Pio, and to whom more fake quotes have been attributed. Combine that with the phenomenon of the internet, whenever I see, "Padre Pio did ..." or "Padre Pio said ..." I find there's a 90% chance it's not true.