Of course he has rights. He has the right to his children.
If she wants to go...GO...but both children stay and he should contact a lawyer right now to make it so.
Also, where is she getting the money for this trip? If it's from him or his account or a joint account, clean them out NOW. Let the new guy pay for the trip. Any past promises made about money are now null and void as they don't relate to this kind of situation.
You're conflating two issue here. First you're worried about the "emotional affair", which is completely moot. It's also moot about where she got the money. Children are a completely separate issue. Given that neither your brother nor the woman seem to have a high sense of Catholic morals, is it better of the children were to stay with him vs. with the woman. In the court, there would likely be some joint custody situation, since the courts acknowledge "common law" relationships.
But he is required to separate from living in sin with here ANYWAY, regardless of this "emotional affair".